Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix orthogonal interpolation #284

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

pr4deepr
Copy link
Member

Bug fix for issues:

Waiting for confirmation from @oleksiievetsno before merging.

Cheers
Pradeep

Copy link
Member Author

@pr4deepr pr4deepr Jun 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haesleinhuepf I think we ran some of the notebooks before we made some kernel changes, especially the flip z for backward compatbility
As far as I can tell, there are no breaking changes downstream..

@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2023

Codecov Report

Patch coverage: 88.88% and project coverage change: -0.01% ⚠️

Comparison is base (efb38e9) 92.95% compared to head (4b879f8) 92.95%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #284      +/-   ##
==========================================
- Coverage   92.95%   92.95%   -0.01%     
==========================================
  Files         772      772              
  Lines       14300    14304       +4     
==========================================
+ Hits        13293    13296       +3     
- Misses       1007     1008       +1     
Files Changed Coverage Δ
pyclesperanto_prototype/_tier8/_deskew_y.py 84.21% <75.00%> (-3.29%) ⬇️
...to_prototype/_tier8/_affine_transform_deskew_3d.py 94.28% <100.00%> (ø)
tests/test_skimage_imsave.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr4deepr
Copy link
Member Author

pr4deepr commented Jun 8, 2023

Hi @haesleinhuepf
I've checked the notebooks,
Minor issue with displaying the transposed images using cle.imshow:
https://github.com/clEsperanto/pyclesperanto_prototype/blob/dc1c641db5e39e5d1cca2edd53c52becdacc38b6/demo/transforms/deskew.ipynb

Cheers
Pradeep

@pr4deepr pr4deepr requested a review from haesleinhuepf June 19, 2023 01:14
@pr4deepr
Copy link
Member Author

@haesleinhuepf

The error for tests is related to test_skimage_imsave function:

FAILED tests/test_skimage_imsave.py::test_skimage_imsave - ValueError: not enough samples for <PHOTOMETRIC.RGB: 2>: expected 3, got 1

For some reason it fails for python 3.8, 3.9, 3.10

@pr4deepr
Copy link
Member Author

@haesleinhuepf , I modified the test to make test_skimage_save test work. Changes here:
a6fdaab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants