Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow pyclesperanto_prototype images as parameter values #244

Merged
merged 3 commits into from
Sep 29, 2024

Conversation

haesleinhuepf
Copy link
Member

Hi @StRigaud ,

this enables passing pyclesperanto_prototype arrays/images as values. The analogous change on the prototype side is here:

At the end it must be possible to pass both image types to functions of both libraries to optimize interoperability. At the end this notebook must work:

https://github.com/clEsperanto/pyclesperanto_prototype/blob/fbbad2696d95a752a5df9e5772057b27be357be2/demo/interoperability/non-prototype.ipynb

Best,
Robert

@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.94%. Comparing base (5e35602) to head (cbbba62).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #244   +/-   ##
=======================================
  Coverage   87.94%   87.94%           
=======================================
  Files          20       20           
  Lines        1643     1643           
=======================================
  Hits         1445     1445           
  Misses        198      198           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@StRigaud
Copy link
Member

Will test and merge this for the 0.13.2

@StRigaud StRigaud merged commit 72c8746 into main Sep 29, 2024
7 checks passed
@StRigaud StRigaud deleted the compatibility-with-prototype branch October 15, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants