Add missing types for ImageJ #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
|
This pull request adds the missing data types int8, int16, int32 and uint32 to the imageplus converter. It also contains the corresponding push and pull tests for imageplus. |
Merged
|
No more error on my side after a quick test running this: I have the correct output. Simple question though is it normal the output is of type
|
|
my bad, the return is 32-bit |
|
@StRigaud pending all the checks pass this branch should be ready to be merged into main |
|
One remark is that the tests might fail at some point if many actions are running in parallel and the runners run out of memory. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request was created from branch, so that needs to happens first.
This addresses #60