Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a new plugin for indexing repeating subfields #414

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

amercader
Copy link
Member

The scheming_subfields_index plugin will group the values of the same subfields in a text field that will make the values findable.
They are indexed as extras_{field_name}__{key}. extras_* is a dynamic text Solr field that will allow free-text search on these
values.

Added tests and updated the docs.

@wardi let me know what do you think and if you want to keep the scheming_nerf_index plugin or remove it in favour of this one.

Note: the test failure is a Python 2 one, support for which is removed in #413

The `scheming_subfields_index` plugin will group the values of the
same subfields in a text field that will make the values findable.
They are indexed as `extras_{field_name}__{key}`. `extras_*` is a
dynamic `text` Solr field that will allow free-text search on these
values.

Added tests and updated the docs.
Copy link
Contributor

@wardi wardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, please resolve conflict and merge. We can keep the scheming_nerf_index plugin in the code but mark is as deprecated and recommend use of scheming_subfields_index instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants