Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3441713 by RichardGaunt: Layout error when another theme renders a node. #1243

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

richardgaunt
Copy link
Collaborator

@richardgaunt richardgaunt commented Apr 18, 2024

Issue Link: https://www.drupal.org/project/civictheme/issues/3441713

Checklist before requesting a review

  • I have formatted the subject to include ticket number as [CS-123] Verb in past tense with dot at the end.
  • I have added a link to the issue tracker
  • I have provided information in Changed section about WHY something was done if this was not a normal implementation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have run new and existing relevant tests locally with my changes, and they passed
  • I have provided screenshots, where applicable

Changed

  1. Inlined component layout template into drupal layout template:

see:
https://github.com/civictheme/uikit/blob/main/components/00-base/layout/content-layout--single-column.twig
https://github.com/civictheme/uikit/blob/main/components/00-base/layout/content-layout--single-column-contained.twig

This isn't a complete solution as it includes a ui kit component within the theme but demonstrates the fix required for the linked issue.

@AlexSkrypnyk AlexSkrypnyk added State: DO NOT MERGE Do not merge this pull request State: Do not review Do not review this pull request labels Apr 18, 2024
@AlexSkrypnyk
Copy link
Contributor

@richardgaunt
This solution perfectly fits with a new direction! Thank you

@AlexSkrypnyk AlexSkrypnyk changed the title [3441713] - Removed CivicTheme components from Layout templates. Issue #3441713 by RichardGaunt: Layout error when another theme renders a node. Jun 17, 2024
@AlexSkrypnyk AlexSkrypnyk merged commit 2c9c78a into civictheme:develop Jun 17, 2024
10 checks passed
@richardgaunt richardgaunt deleted the 3441713 branch December 27, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
State: DO NOT MERGE Do not merge this pull request State: Do not review Do not review this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants