Issue #3415665 by joshua1234511: Utilize Focal Point module #1242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-salsadigital
changed the title
| /** | ||
| * Defines the image style constants. | ||
| */ | ||
| const PROMO_IMAGE_STYLE = 'civictheme_promo_card'; |
There was a problem hiding this comment.
@AlexSkrypnyk We need to decide on which style to be used for each type of cards.
There was a problem hiding this comment.
@joshua-salsadigital
yep. we need to have an image style per component.
- Please use exact component names in variables
PROMO_IMAGE_STYLE->PROMO_CARD_IMAGE_STYLEetc. - There should be a dedicated image style per constant below. If it does not exist -please create one.
civictheme_thumbnailshould not be used anymore - please asses all areas where it is used and replace with a specific named image style. The style values would be copied from thecivictheme_thumbnailat this stage + focal point adjustments. - Remove
civictheme_thumbnailYAML from the config and create an update hook to remove it.
joshua-salsadigital
force-pushed
the
feature/3415665-focul-point
branch
from
9f976ec to
fd1c470
Compare
| * | ||
| * @Then I( should) see the :selector element with the :attribute attribute like :pattern | ||
| */ | ||
| public function elementAssertAttributeLikePattern(string $selector, string $attribute, string $pattern): void { |
There was a problem hiding this comment.
This does not need to check for the wildcard - it checks if the attribute contains a string.
Please update to
@Then I( should) see the :selector element with a(n) :attribute attribute containing :value
The method then will become elementAssertAttributeContains
AlexSkrypnyk
suggested changes
Apr 18, 2024
There was a problem hiding this comment.
@joshua-salsadigital
the PR looks good!
Please see my inline comments re tests and naming of the image styles.
joshua-salsadigital
added
the
State: Needs review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.drupal.org/project/civictheme/issues/3415665
Checklist before requesting a review
[CS-123] Verb in past tense with dot at the end.Changedsection about WHY something was done if this was not a normal implementationChanged
focal_pointmodule incivictheme.info.ymlfile.Screenshots