Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIVIC-1707] Created Storybook link in the secondary navigation and updated redirect. #1228

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

joshua-salsadigital
Copy link
Collaborator

@joshua-salsadigital joshua-salsadigital commented Mar 13, 2024

https://salsadigital.atlassian.net/browse/CIVIC-1707

Checklist before requesting a review

  • I have formatted the subject to include ticket number as [CS-123] Verb in past tense with dot at the end.
  • I have added a link to the issue tracker
  • I have provided information in Changed section about WHY something was done if this was not a normal implementation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have run new and existing relevant tests locally with my changes, and they passed
  • I have provided screenshots, where applicable

Changed

  1. Updated redirect in code to use themes/custom/civictheme_demo/storybook-static/index.html
  2. Updated Default content profile to add a Storybook menu item before “Generated content” link in the secondary navigation in the header.

Screenshots

Screenshot 2024-03-13 at 8 25 11 AM

@joshua-salsadigital joshua-salsadigital added the State: Needs review Pull requests needs a review from assigned developers label Mar 13, 2024
@joshua-salsadigital joshua-salsadigital self-assigned this Mar 13, 2024
@AlexSkrypnyk AlexSkrypnyk merged commit 16d1438 into develop Mar 13, 2024
12 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the feature/CIVIC-1707 branch March 13, 2024 04:03
@sonamchaturvedi28
Copy link

Test Status: PASS
Test ResuIt:

  • Storybook menu is added in the secondary navigation in the header.
  • The redirect is working
Screenshot 2024-03-14 at 11 06 56 AM Screenshot 2024-03-14 at 11 07 22 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
State: Needs review Pull requests needs a review from assigned developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants