Issue #3421251] by joshua1234511, alex.skrypnyk: Navigation sidebar not expanding sub-links automatically #1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-salsadigital
added
the
State: Needs review
| @@ -31,5 +29,8 @@ function civictheme_preprocess_block__menu_block__civictheme_primary_navigation( | |||
|
|
|||
| if (str_starts_with($region, 'sidebar')) { | |||
| $variables['in_sidebar'] = TRUE; | |||
| $expand_all_items = $variables['configuration']['expand_all_items'] ?? FALSE; | |||
There was a problem hiding this comment.
Added override only for sidebar regions, (Header navigation wont be effected - they will still follow individual menu item settings)
AlexSkrypnyk
changed the title
AlexSkrypnyk
approved these changes
Mar 12, 2024
AlexSkrypnyk
added a commit
that referenced
this pull request
Mar 12, 2024
…t expanding sub-links automatically (#1226) Co-authored-by: Joshua Fernandes <“[email protected]”> Co-authored-by: Alex Skrypnyk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.drupal.org/project/civictheme/issues/3421251
Checklist before requesting a review
[CS-123] Verb in past tense with dot at the end.Changedsection about WHY something was done if this was not a normal implementationChanged
Screenshots
https://nimb.ws/UJdh0Wq
screencast-monorepo-drupal.docker.amazee.io-2024.03.12-18_31_00.webm