Pull images included within compose service definitions prior to terr… #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xOI
force-pushed
the
add_image_prepull_terraform
branch
2 times, most recently
from
b0c8c92 to
faf34af
Compare
…aform Ensure all images included within constructed `docker-compose` command are pulled in parallel prior to stand-up. [OF6-1396]
0xOI
force-pushed
the
add_image_prepull_terraform
branch
from
faf34af to
d72de51
Compare
0xOI
commented
Dec 7, 2018
|
|
||
| pull_cmd="${pull_args[@]}" | ||
| docker exec $container_name bash -c "\ | ||
| # change directory to temporary workspace |
There was a problem hiding this comment.
more reasonable comment here
0xOI
commented
Dec 7, 2018
| docker exec $container_name bash -c "\ | ||
| # change directory to temporary workspace | ||
| cd $tmp_workspace; | ||
| # pull compose service images |
There was a problem hiding this comment.
remove comment and convert to: cd $tmp_workspace && $pull_cmd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure all images included within constructed
docker-composecommandare pulled in parallel prior to stand-up.
[OF6-1396]