Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump docker to version 10.2.1 #268

Merged
merged 22 commits into from
Sep 28, 2021
Merged

Bump docker to version 10.2.1 #268

merged 22 commits into from
Sep 28, 2021

Conversation

gurkanindibay
Copy link
Contributor

No description provided.

@onurctirtir onurctirtir self-requested a review September 22, 2021 09:06
hanefi
hanefi previously approved these changes Sep 22, 2021
View reviewed changes
Copy link
Member

@hanefi hanefi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs some updates after citusdata/tools#187 is merged and we create a new tag.

.github/workflows/publish_docker_images_on_manual.yml Outdated Show resolved Hide resolved
.github/workflows/publish_docker_images_on_push.yml Outdated Show resolved Hide resolved
.github/workflows/update_version.yml Outdated Show resolved Hide resolved
@hanefi hanefi dismissed their stale review September 24, 2021 12:18

I saw some missing items in the commits after my approval

hanefi
hanefi requested changes Sep 24, 2021
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
postgres-14/Dockerfile Outdated Show resolved Hide resolved
postgres-14/Dockerfile Outdated Show resolved Hide resolved
postgres-14/Dockerfile Outdated Show resolved Hide resolved
@gurkanindibay
Downgrades postgres 13 and 12 image versions
52dd6c3 
since latest versions are debian 11
gurkanindibay and others added 2 commits September 24, 2021 17:55
@gurkanindibay @hanefi
Update postgres-14/Dockerfile
63f31da 
Co-authored-by: Hanefi Onaldi <[email protected]>
@gurkanindibay
Rollbacks postgres 14 version
8b1423c 
since RC1 base image is debian 11 based
hanefi
hanefi requested changes Sep 24, 2021
View reviewed changes
.github/workflows/publish_docker_images_cron.yml Outdated Show resolved Hide resolved
.github/workflows/update_version.yml Outdated Show resolved Hide resolved
nightly/Dockerfile Outdated Show resolved Hide resolved
postgres-14/Dockerfile Outdated Show resolved Hide resolved
postgres-14/Dockerfile Outdated Show resolved Hide resolved
hanefi
hanefi reviewed Sep 24, 2021
View reviewed changes
postgres-14/Dockerfile Outdated Show resolved Hide resolved
hanefi
hanefi requested changes Sep 24, 2021
View reviewed changes
.github/workflows/publish_docker_images_on_manual.yml Outdated Show resolved Hide resolved
nightly/Dockerfile Outdated Show resolved Hide resolved
nightly/Dockerfile Outdated Show resolved Hide resolved
postgres-14/Dockerfile Outdated Show resolved Hide resolved
hanefi
hanefi requested changes Sep 27, 2021
View reviewed changes
.github/workflows/publish_docker_images_on_push.yml Outdated Show resolved Hide resolved
postgres-14/Dockerfile Outdated Show resolved Hide resolved
postgres-14/Dockerfile Outdated Show resolved Hide resolved
postgres-14/Dockerfile Outdated Show resolved Hide resolved
postgres-14/Dockerfile Outdated Show resolved Hide resolved
postgres-14/Dockerfile Outdated Show resolved Hide resolved
hanefi
hanefi requested changes Sep 27, 2021
View reviewed changes
postgres-14/Dockerfile Outdated Show resolved Hide resolved
postgres-14/Dockerfile Outdated Show resolved Hide resolved
postgres-14/Dockerfile Outdated Show resolved Hide resolved
hanefi
hanefi requested changes Sep 27, 2021
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
postgres-14/Dockerfile Outdated Show resolved Hide resolved
postgres-14/Dockerfile Outdated Show resolved Hide resolved
@gurkanindibay gurkanindibay linked an issue Sep 28, 2021 that may be closed by this pull request
Create a template structure to manage docker files #271
Open
hanefi
hanefi approved these changes Sep 28, 2021
View reviewed changes
Copy link
Member

@hanefi hanefi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the PR title and description before merging this one.

@gurkanindibay gurkanindibay merged commit 26dac63 into master Sep 28, 2021
@gurkanindibay gurkanindibay changed the title Changes pg13 as main image and moves pg14 into directory Bump docker to version 10.2.1 Sep 28, 2021
@hanefi hanefi deleted the docker-13-as-main branch September 28, 2021 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onurctirtir onurctirtir onurctirtir approved these changes

@hanefi hanefi hanefi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a template structure to manage docker files
3 participants
@gurkanindibay @hanefi @onurctirtir