Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove automatic sql variable extraction #991

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

bbortt
Copy link
Collaborator

@bbortt bbortt commented Sep 18, 2023

one must explicitly call extract using column- plut target-variable-names in order to extract data from the result into the current TestContext.

BREAKING CHANGE: sql queries no longer automatically extract variables

@bbortt
Copy link
Collaborator Author

bbortt commented Sep 19, 2023

looks like I forgot to hit git push on my computer yesterday :D I've already fixed the build...

Copy link
Member

@christophd christophd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, but PR checks still failing

@bbortt
Copy link
Collaborator Author

bbortt commented Sep 25, 2023

Good, but PR checks still failing

I know, didn't have time to look into it yet. possibly this evening!

one must explicitly call `extract` using column- plut target-variable-names
in order to extract data from the result into the current `TestContext`.

BREAKING CHANGE: sql queries no longer automatically extract variables
@bbortt bbortt force-pushed the issues/984-sql-action branch from 9ad9105 to 44ba422 Compare September 26, 2023 12:35
@bbortt bbortt merged commit 82d985f into main Oct 6, 2023
1 check passed
@bbortt bbortt deleted the issues/984-sql-action branch October 6, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants