feat(#976): Disable/Override standard Citrus reporters #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tschlat
force-pushed
the
issue/976/disable_default_reporters
branch
2 times, most recently
from
43d2311 to
c82eea8
Compare
bbortt
reviewed
Sep 17, 2023
core/citrus-spring/src/main/java/org/citrusframework/reporter/ReporterConfig.java
Outdated
Show resolved
Hide resolved
bbortt
reviewed
Sep 17, 2023
core/citrus-spring/src/test/java/org/citrusframework/reporter/OverrideReporterConfigTest.java
Outdated
Show resolved
Hide resolved
bbortt
reviewed
Sep 17, 2023
src/manual/reporting.adoc
Outdated
|
|
||
| [source,java] | ||
| ---- | ||
| @Configuration |
There was a problem hiding this comment.
Suggested change
| @Configuration | |
| @Configuration |
bbortt
reviewed
Sep 17, 2023
tschlat
force-pushed
the
issue/976/disable_default_reporters
branch
from
c82eea8 to
a0e4c25
Compare
|
I have added one more test. |
bbortt
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The requested feature has been implemented as follows: when you add an override implementation of a Reporter through Spring Configuration, it will automatically suppress the default Citrus reporter. Additionally, if you set the enablement property to 'false,' the Reporter will also be suppressed.
Please note that not all Reporters can be disabled due to Autowiring requirements, and there may be limitations on adding additional reporters through single bean matching. For me it makes most sense, to just override an existing Reporter with an own implementation.
If you have any comments or further requests, feel free to comment.