Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow WITH sql keyword for query action #985

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Conversation

bbortt
Copy link
Collaborator

@bbortt bbortt commented Sep 15, 2023

closes #984.

the `WITH` clause (also known as Common Table Expressions (CTEs)) is part of the SQL standard SQL:1999.
according to the [list of SQL reserved words](https://en.wikipedia.org/wiki/List_of_SQL_reserved_words)
all modern databases support it (as they should).
@bbortt bbortt force-pushed the issues/984-sql-action branch from a45a170 to fed0d3a Compare September 15, 2023 13:11
@bbortt
Copy link
Collaborator Author

bbortt commented Sep 15, 2023

@christophd I also found this while looking through the code:

// legacy: save all columns as variables TODO: remove in major version upgrade

shall I remove it?

@christophd
Copy link
Member

@christophd I also found this while looking through the code:

// legacy: save all columns as variables TODO: remove in major version upgrade

shall I remove it?

yes, if not now when should we do it. please go ahead

Copy link
Member

@christophd christophd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@bbortt bbortt merged commit 45b6935 into main Sep 18, 2023
1 check passed
@bbortt bbortt deleted the issues/984-sql-action branch September 18, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

query statements may not start using the 'WITH' keyword
2 participants