fix(#978): Allow custom http status codes #981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbortt
requested changes
Sep 13, 2023
...est-generator/src/main/java/org/citrusframework/generate/provider/http/HttpCodeProvider.java
Outdated
Show resolved
Hide resolved
.../main/java/org/citrusframework/generate/provider/http/ReceiveHttpResponseActionProvider.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/citrusframework/generate/provider/http/SendHttpResponseActionProvider.java
Outdated
Show resolved
Hide resolved
bbortt
approved these changes
Sep 15, 2023
Co-authored-by: Timon Borter <[email protected]>
bbortt
force-pushed
the
feat/make-inbound-message-generation-more-robust
branch
from
93a3f74 to
8ea65e2
Compare
|
@Tom-29 I've squashed your commits. whenever you apply a suggestion directly in GitHub, you're creating new commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will fix Issue 978. There are a few breaking changes because
HttpMessageuses nowHttpStatusCodeinstead of theHttpStatusenum. I also removed theHttpMessage.statusCode(Integer)and theHttpMessage.status(HttpStatus)method because they are no longer necessary.HttpMessage.getStatusCode()returns now aHttpStatusCodeinstead of aHttpStatus.