Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add timeout to iterating action containers #1261

Merged
merged 1 commit into from
Nov 12, 2024
Merged

add timeout to iterating action containers #1261

merged 1 commit into from
Nov 12, 2024

Conversation

bbortt
Copy link
Collaborator

@bbortt bbortt commented Nov 9, 2024 •
edited
Loading

as promised, a timeout implementation on all iterating actions. this is currently:

  • repeat until condition
  • repeat on error
  • iterate

this will partially help with #1258, because the kafka IT's won't run forever.

@bbortt bbortt self-assigned this Nov 9, 2024
@bbortt bbortt force-pushed the fix/iterating-actions-with-timeout branch from a0716b9 to 941409d Compare November 9, 2024 14:38
@bbortt bbortt changed the title Draft: add timeout to iterating action containers add timeout to iterating action containers Nov 9, 2024
@bbortt bbortt requested a review from christophd November 9, 2024 14:39
@bbortt bbortt added Type: Enhancement Prio: High State: Review If pull-request has been opened an is ready/in review labels Nov 9, 2024
@bbortt
Copy link
Collaborator Author

bbortt commented Nov 9, 2024

wll, that works: https://github.com/citrusframework/citrus/actions/runs/11757100929/job/32753963702?pr=1261#step:6:16585.

christophd
christophd approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@christophd christophd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks!

@bbortt bbortt merged commit 578595a into citrusframework:main Nov 12, 2024
1 check passed
@bbortt bbortt deleted the fix/iterating-actions-with-timeout branch November 12, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophd christophd christophd approved these changes

Assignees

@bbortt bbortt

Labels
Prio: High State: Review If pull-request has been opened an is ready/in review Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bbortt @christophd