Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disallow access into ws interceptors #1237

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

bbortt
Copy link
Collaborator

@bbortt bbortt commented Oct 17, 2024

problem; access to interceptors list is exposed to public. modifications to it won't be propagated to the underlying web service template.

I personally find this a bit irritating. I think the acessor methods could be used instead, that's what this PR would change.

see this (unchanged) setter implementation:

    public void setInterceptors(List<ClientInterceptor> interceptors) {
        this.interceptors = interceptors;
        getWebServiceTemplate().setInterceptors(interceptors.toArray(new ClientInterceptor[0]));
    }

@bbortt bbortt self-assigned this Oct 17, 2024
@christophd
Copy link
Member

could you please elaborate why this has been an issue, thx

@bbortt bbortt requested a review from christophd October 20, 2024 15:28
@bbortt
Copy link
Collaborator Author

bbortt commented Oct 20, 2024

could you please elaborate why this has been an issue, thx

@christophd updated the PR description.

Copy link
Member

@christophd christophd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

many thanks

@bbortt bbortt merged commit 1ac97c4 into citrusframework:main Oct 21, 2024
1 check passed
@bbortt bbortt deleted the fix/ws-accessor branch October 21, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants