Slim down dependency from docker-java to docker-java-core #1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apupier
force-pushed
the
slimDownDockerJavaDependency
branch
from
82aa944 to
071a09e
Compare
|
last error is not related to my change: and found same test failure on main branch: https://github.com/citrusframework/citrus/actions/runs/6547583443/job/17780353679#step:6:2340 but I cannot trigger another build manually. I will push a dummy change to the commit message of my PR |
apupier
force-pushed
the
slimDownDockerJavaDependency
branch
from
071a09e to
a029f7a
Compare
* It has the main benefit to not have anymore a dependency on Netty. * it is reducing the size of dependencies Signed-off-by: Aurélien Pupier <[email protected]>
apupier
force-pushed
the
slimDownDockerJavaDependency
branch
from
a029f7a to
3683297
Compare
christophd
approved these changes
Oct 17, 2023
see reported flaky test in #1018. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it has the main benefit to not have anymore a dependency on Netty
In getting started of docker-java, they are mentioning to use docker-java-core (and not docker-java): https://github.com/docker-java/docker-java/blob/main/docs/getting_started.md#dependencies
(it is comforting me in the fact that it should work nicely)