chore(citrus-test-api-generator-core): review and code cleanup

pr: #1224 `citrus-test-api-generator-core` module.
citrusframework · Oct 28, 2024 · 8e3436b · 8e3436b
1 parent 7f881fd
commit 8e3436b
Show file tree

Hide file tree

Showing 45 changed files with 3,379 additions and 3,231 deletions.
diff --git a/pom.xml b/pom.xml
@@ -165,7 +165,7 @@
     <maven.assembly.plugin.version>3.6.0</maven.assembly.plugin.version>
     <maven.changes.plugin.version>2.12.1</maven.changes.plugin.version>
     <maven.clean.plugin.version>3.3.1</maven.clean.plugin.version>
-    <maven.dependency.plugin.version>3.6.0</maven.dependency.plugin.version>
+    <maven.dependency.plugin.version>3.7.1</maven.dependency.plugin.version>
     <maven.deploy.plugin.version>3.1.1</maven.deploy.plugin.version>
     <maven.failsafe.plugin.version>2.22.2</maven.failsafe.plugin.version>
     <maven.gpg.plugin.version>1.6</maven.gpg.plugin.version>

diff --git a/test-api-generator/citrus-test-api-generator-core/README.md b/test-api-generator/citrus-test-api-generator-core/README.md
@@ -44,7 +44,7 @@ public class PetsApi {
     }
 
     /**
-     * Builder with required parameters as string to allow for dynamic content.
+     * Builder with required parameters as string, allowing dynamic content using citrus expressions.
      */
     public DeletePetRequestActionBuilder sendDeletePet$(String petIdExpression) {
         DeletePetRequestActionBuilder builder = new DeletePetRequestActionBuilder(petIdExpression, openApiSpecification);

diff --git a/test-api-generator/citrus-test-api-generator-core/pom.xml b/test-api-generator/citrus-test-api-generator-core/pom.xml
@@ -1,7 +1,7 @@
 <project
-    xmlns="http://maven.apache.org/POM/4.0.0"
-    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-    xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"
+        xmlns="http://maven.apache.org/POM/4.0.0"
+        xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+        xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"
 >
     <modelVersion>4.0.0</modelVersion>
     <parent>
@@ -152,14 +152,16 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-dependency-plugin</artifactId>
-                <version>3.7.1</version>
+                <version>${maven.dependency.plugin.version}</version>
                 <configuration>
                     <artifactItems>
                         <artifactItem>
                             <groupId>org.openapitools</groupId>
                             <artifactId>openapi-generator</artifactId>
                             <version>${org.openapitools.version}</version>
-                            <includes>Java/*Annotation*.mustache,Java/*Model*.mustache,Java/model*.mustache,Java/pojo*.mustache</includes>
+                            <includes>
+                                Java/*Annotation*.mustache,Java/*Model*.mustache,Java/model*.mustache,Java/pojo*.mustache
+                            </includes>
                         </artifactItem>
                     </artifactItems>
                     <outputDirectory>
@@ -178,9 +180,9 @@
             </plugin>
 
             <plugin>
-            <groupId>org.apache.maven.plugins</groupId>
-            <artifactId>maven-resources-plugin</artifactId>
-            <version>3.3.1</version>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-resources-plugin</artifactId>
+                <version>${maven.resource.plugin.version}</version>
                 <executions>
                     <execution>
                         <id>prepare-java-templates</id>
@@ -258,7 +260,9 @@
                             <configOptions>
                                 <invokerPackage>org.citrusframework.openapi.generator.rest.extpetstore</invokerPackage>
                                 <apiPackage>org.citrusframework.openapi.generator.rest.extpetstore.request</apiPackage>
-                                <modelPackage>org.citrusframework.openapi.generator.rest.extpetstore.model</modelPackage>
+                                <modelPackage>
+                                    org.citrusframework.openapi.generator.rest.extpetstore.model
+                                </modelPackage>
                                 <prefix>ExtPetStore</prefix>
                                 <apiEndpoint>extpetstore.endpoint</apiEndpoint>
                             </configOptions>
@@ -276,15 +280,16 @@
                                 <apiType>SOAP</apiType>
                                 <invokerPackage>org.citrusframework.openapi.generator.soap.bookservice</invokerPackage>
                                 <apiPackage>org.citrusframework.openapi.generator.soap.bookservice.request</apiPackage>
-                                <modelPackage>org.citrusframework.openapi.generator.soap.bookservice.model</modelPackage>
+                                <modelPackage>
+                                    org.citrusframework.openapi.generator.soap.bookservice.model
+                                </modelPackage>
                                 <prefix>BookService</prefix>
                                 <apiEndpoint>bookstore.endpoint</apiEndpoint>
                             </configOptions>
                         </configuration>
                     </execution>
                 </executions>
             </plugin>
-
         </plugins>
     </build>
 </project>