fix(#1020): use try-with-resource to close buffered readers

* Use try-with-resource to close BufferedReaders * Remove unnecessary semi-colons
citrusframework · Oct 17, 2023 · 85fdbb3 · 85fdbb3
1 parent bee0cd2
commit 85fdbb3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/core/citrus-base/src/main/java/org/citrusframework/actions/InputAction.java b/core/citrus-base/src/main/java/org/citrusframework/actions/InputAction.java
@@ -91,11 +91,9 @@ public void doExecute(TestContext context) {
         }
 
 
-        try {
+        try (BufferedReader stdin = getInputReader()) {
             do {
                 logger.info(display);
-
-                BufferedReader stdin = getInputReader();
                 input = stdin.readLine();
             } while (validAnswers != null && !checkAnswer(input));
         } catch (IOException e) {

diff --git a/...-base/src/main/java/org/citrusframework/validation/script/TemplateBasedScriptBuilder.java b/...-base/src/main/java/org/citrusframework/validation/script/TemplateBasedScriptBuilder.java
@@ -64,9 +64,8 @@ public String build() {
         StringBuilder scriptBody = new StringBuilder();
         String importStmt = "import ";
 
-        try {
+        try (BufferedReader reader = new BufferedReader(new StringReader(scriptCode))) {
             if (scriptCode.contains(importStmt)) {
-                BufferedReader reader = new BufferedReader(new StringReader(scriptCode));
                 String line;
                 while ((line = reader.readLine()) != null) {
                     if (line.trim().startsWith(importStmt)) {