fix: Update Button tag property type to accept strings (#330)

cision · Jul 28, 2021 · aa6d423 · aa6d423
1 parent dab377f
commit aa6d423
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/src/components/Button/Button.tsx b/src/components/Button/Button.tsx
@@ -23,7 +23,7 @@ interface BaseButtonProps {
   hollow?: boolean;
   level?: TButtonLevel;
   size?: TButtonSize;
-  tag?: React.FC<TagType> | React.ComponentType<TagType> | null;
+  tag?: React.FC<TagType> | React.ComponentType<TagType> | string | null;
 
   // States
   hover?: boolean;

diff --git a/src/components/Button/story.tsx b/src/components/Button/story.tsx
@@ -90,7 +90,9 @@ storiesOf('Planets/Button', module)
                 marginBottom: '10px',
               }}
             >
-              <Button href="#">a</Button>
+              <Button href="#" tag="a">
+                a
+              </Button>
             </span>
             <span
               style={{
@@ -99,7 +101,18 @@ storiesOf('Planets/Button', module)
                 marginBottom: '10px',
               }}
             >
-              <Button>button (default)</Button>
+              <Button tag="button" type="button">
+                button (default)
+              </Button>
+            </span>
+            <span
+              style={{
+                display: 'inline-block',
+                marginRight: '20px',
+                marginBottom: '10px',
+              }}
+            >
+              <Button tag="input" type="button" value="input type=button" />
             </span>
           </div>
           <h2>Custom type</h2>