Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the correct packer build commands #384

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Use the correct packer build commands #384

merged 1 commit into from
Dec 11, 2024

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Dec 11, 2024 •
edited
Loading

🗣 Description

This pull request updates the README.md file to use the correct packer build commands for releases and prereleases.

💭 Motivation and context

It is important that the documentation be correct.

🧪 Testing

👀

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • All new and existing tests pass.

@jsf9k jsf9k added the documentation This issue or pull request improves or adds to documentation label Dec 11, 2024
@jsf9k jsf9k self-assigned this Dec 11, 2024
@jsf9k jsf9k mentioned this pull request Dec 11, 2024
Merged
6 tasks
dav3r
dav3r approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@jsf9k jsf9k marked this pull request as ready for review December 11, 2024 19:34
@jsf9k jsf9k requested a review from a team December 11, 2024 19:34
@jsf9k jsf9k added this pull request to the merge queue Dec 11, 2024
Merged via the queue into develop with commit 82a9528 Dec 11, 2024
10 checks passed
@jsf9k jsf9k deleted the documentation/use-correct-packer-build-commands branch December 11, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dv4harr10 dv4harr10 dv4harr10 approved these changes

@mcdonnnj mcdonnnj mcdonnnj approved these changes

@dav3r dav3r dav3r approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

Assignees

@jsf9k jsf9k

Labels
documentation This issue or pull request improves or adds to documentation
Projects
Skeleton Maintenance
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsf9k @dav3r @mcdonnnj @dv4harr10