Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back CDM agents #91

Merged
merged 5 commits into from
Oct 13, 2023
Merged

Add back CDM agents #91

merged 5 commits into from
Oct 13, 2023

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Oct 4, 2023 •
edited
Loading

🗣 Description

This pull request adds back in support for the CDM Tanium and Tenable agents. Support for these agents was removed in #72 and #87 because at that time the agents did not support Debian Bullseye, but now it can be re-added.

💭 Motivation and context

We must include the CDM software in our AMI.

🧪 Testing

All automated tests pass. I also created a staging AMI with these changes and verified that it functions as expected.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.
  • Build and test a staging AMI that contains these changes.

✅ Pre-merge checklist

  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@jsf9k jsf9k added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use version bump This issue or pull request increments the version number dependencies Pull requests that update a dependency file hacktoberfest-accepted Pull request that should count toward Hacktoberfest participation security This issue or pull request addresses a security issue labels Oct 4, 2023
@jsf9k jsf9k self-assigned this Oct 4, 2023
jsf9k added 3 commits October 4, 2023 15:35
@jsf9k
Revert "Remove CDM playbook"
a1ca743 
This reverts commit c688c62, adding
back support for the CDM Tanium and Tenable agents.
@jsf9k
Bump version from 0.3.6 to 0.3.7
dec956e
@jsf9k
Bump version from 0.3.7 to 0.3.7-rc.1
af606f8
@jsf9k jsf9k force-pushed the improvement/add-back-cdm-tools branch from 2e5507e to af606f8 Compare October 4, 2023 19:35
@jsf9k
Revert "Update TF code for build user"
e70b591 
This _partially_ reverts commit
c1c62c4, adding back in the necessary
support for the Nessus and Tanium CDM agents.
@jsf9k jsf9k marked this pull request as ready for review October 5, 2023 15:48
@jsf9k jsf9k requested a review from a team October 5, 2023 15:48
@jsf9k jsf9k enabled auto-merge October 5, 2023 15:49
@jsf9k jsf9k disabled auto-merge October 11, 2023 15:26
dav3r
dav3r approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@jsf9k jsf9k enabled auto-merge October 13, 2023 15:12
@jsf9k jsf9k merged commit 793f5d4 into develop Oct 13, 2023
6 checks passed
@jsf9k jsf9k deleted the improvement/add-back-cdm-tools branch October 13, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dv4harr10 dv4harr10 dv4harr10 approved these changes

@dav3r dav3r dav3r approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

@jasonodoom jasonodoom Awaiting requested review from jasonodoom

@mcdonnnj mcdonnnj Awaiting requested review from mcdonnnj mcdonnnj is a code owner

Assignees

@jsf9k jsf9k

Labels
dependencies Pull requests that update a dependency file hacktoberfest-accepted Pull request that should count toward Hacktoberfest participation improvement This issue or pull request will add or improve functionality, maintainability, or ease of use security This issue or pull request addresses a security issue version bump This issue or pull request increments the version number
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsf9k @dav3r @dv4harr10