Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to refresh AMI #118

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Bump version to refresh AMI #118

merged 2 commits into from
Jan 8, 2025

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Jan 7, 2025

🗣 Description

This pull request bumps the build version so we can build a fresh AMI.

💭 Motivation and context

The current AMI is getting a little long in the tooth.

🧪 Testing

All automated tests pass. I also built a pre-release, deployed it to our staging COOL environment, and verified that it functions as expected.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.
  • Build and test a pre-release with these changes.

✅ Pre-merge checklist

  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@jsf9k jsf9k added the version bump This issue or pull request increments the version number label Jan 7, 2025
@jsf9k jsf9k self-assigned this Jan 7, 2025
@jsf9k jsf9k marked this pull request as ready for review January 7, 2025 22:47
@jsf9k jsf9k requested a review from a team January 7, 2025 22:47
@jsf9k jsf9k enabled auto-merge January 7, 2025 22:48
version.txt Show resolved Hide resolved
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with the prerelease being 1.0.1+build.1 and the release being 1.0.1+build.2. It may not be perfect, but it's simple and I haven't heard any better ideas.

@jsf9k jsf9k merged commit 55205a8 into develop Jan 8, 2025
10 checks passed
@jsf9k jsf9k deleted the version_bump branch January 8, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version bump This issue or pull request increments the version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants