Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attachments and templates to email notification. #2432

Merged

Conversation

JCantu248
Copy link
Contributor

@JCantu248 JCantu248 commented Dec 22, 2023

🗣 Description

Since html emails are working, try adding handlebar templates and S3 attachments with an await.

💭 Motivation and context

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@JCantu248 JCantu248 requested a review from nickviola December 22, 2023 21:56
Copy link
Contributor

@nickviola nickviola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@schmelz21
Copy link
Collaborator

@JCantu248 , @nickviola - Is this branch OBE?

@cduhn17 cduhn17 assigned cduhn17 and unassigned cduhn17 Jan 2, 2024
@cduhn17 cduhn17 self-requested a review January 2, 2024 19:30
Copy link
Contributor

@cduhn17 cduhn17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JCantu248 JCantu248 merged commit 751de0c into master Jan 3, 2024
15 checks passed
@JCantu248 JCantu248 deleted the issue-2380/user_notification_email_attachments_templates branch January 3, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants