Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing test for censys.ts #2428

Merged
merged 4 commits into from
Dec 22, 2023
Merged

Fix failing test for censys.ts #2428

merged 4 commits into from
Dec 22, 2023

Conversation

Matthew-Grayson
Copy link
Contributor

@Matthew-Grayson Matthew-Grayson commented Dec 21, 2023

🗣 Description

Updated censys.test.ts to mock the v2 api endpoint.
Reverted data in mocked api response and updated snapshot to match.
Normalize domain names to remove www.

💭 Motivation and context

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@Matthew-Grayson Matthew-Grayson self-assigned this Dec 21, 2023
@Matthew-Grayson Matthew-Grayson changed the title Reverted test data and updated snapshot for censys.ts. Fix failing test for censys.ts Dec 21, 2023
@Matthew-Grayson Matthew-Grayson marked this pull request as ready for review December 21, 2023 17:55
@Matthew-Grayson Matthew-Grayson marked this pull request as draft December 21, 2023 18:40
@Matthew-Grayson Matthew-Grayson marked this pull request as ready for review December 21, 2023 19:32
Copy link
Contributor

@nickviola nickviola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tests all seem to be passing now and the output re-formatting is al described well in the code comments.

Copy link
Contributor

@cduhn17 cduhn17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im assuming the data that is included in the test files is fake or acceptable?

@cduhn17 cduhn17 merged commit fe11a65 into master Dec 22, 2023
13 of 15 checks passed
@cduhn17 cduhn17 deleted the 1857-fix-censys-scans branch December 22, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants