Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic text and html email logic to user registration #2424

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

nickviola
Copy link
Contributor

@nickviola nickviola commented Dec 21, 2023

🗣 Description

Adding new email functions for basic testing of text and html formats.
part of #2380

💭 Motivation and context

Testing User registration email notification process.

🧪 Testing

Verify email is sent on registration signup.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@nickviola nickviola self-assigned this Dec 21, 2023
@nickviola
Copy link
Contributor Author

Vulnerability failures and censys 401 test failure will be addressed in separate PRs.

@nickviola nickviola marked this pull request as ready for review December 21, 2023 14:47
Copy link
Collaborator

@schmelz21 schmelz21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve to run email testing.

@nickviola nickviola merged commit 5c2cd9f into master Dec 21, 2023
12 of 15 checks passed
@nickviola nickviola deleted the issue-2380/testing-basic-email-functionality branch December 21, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants