Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 2406/add email template s3 logic #2407

Merged
merged 17 commits into from
Dec 11, 2023
Merged

Issue 2406/add email template s3 logic #2407

merged 17 commits into from
Dec 11, 2023

Conversation

nickviola
Copy link
Contributor

@nickviola nickviola commented Dec 7, 2023 •
edited
Loading

🗣 Description

💭 Motivation and context

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 7, 2023
View reviewed changes
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@nickviola nickviola marked this pull request as ready for review December 11, 2023 20:52
@nickviola
Copy link
Contributor Author

Confirmed that vulnerabilities will be addressed in a separate PR.

ameliav
ameliav approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@ameliav ameliav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nickviola nickviola merged commit 136086a into master Dec 11, 2023
10 of 13 checks passed
@nickviola nickviola deleted the issue-2406/add-email-template-s3-logic branch December 11, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JCantu248 JCantu248 JCantu248 left review comments

@ameliav ameliav ameliav approved these changes

@schmelz21 schmelz21 Awaiting requested review from schmelz21 schmelz21 is a code owner

Assignees

@nickviola nickviola

@JCantu248 JCantu248

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickviola @ameliav @JCantu248