-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-design Vulnerability details page #2352
Re-design Vulnerability details page #2352
Conversation
…tps://github.com/cisagov/crossfeed into 2306-redesign-vuln-details-page-overview-section
…thub.com:cisagov/crossfeed into 2306-redesign-vuln-details-page-overview-section
@ameliav , upon review please remove the CWE Name reference and move forward with merging the Vuln details page in its current state. We will Issue separate tickets to support the notes section and the CWE name. They both require more detailed planning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the TODO comments in the code are a bit disconcerting (e.g. //TODO: change this to something else??)
Understandable. There are just a few things about the new tables that don't match the rest of the code base. The column names for one thing use snake case instead of camel case. This adds confusion to development when displaying detailed information from API responses. I think we should make these changes before the new tables are deployed to production. I'll create an issue and link it. |
…g important info at the the top and keeping arrays and joins at the bottom.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - One comment, on TODOs moving forward, I believe it will be required in future reviews to reference the Issue number also in the code.
🗣 Description
Re-design the current Vulnerability details page. Completes issues: #2306, #2307, #2308, #2309
💭 Motivation and context
Change makes for a better user interface for the Vulnerability details page.
🧪 Testing
✅ Pre-approval checklist
in code comments.
to reflect the changes in this PR.
✅ Pre-merge checklist
✅ Post-merge checklist