-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cloudwatch to s3 lambda #2305
Merged
Merged
Cloudwatch to s3 lambda #2305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g); refactor variable names for consistency with project.
…et are saved to logging bucket.
Matthew-Grayson
temporarily deployed
to
production
October 13, 2023 14:00 — with
GitHub Actions
Inactive
Matthew-Grayson
temporarily deployed
to
staging
October 13, 2023 14:00 — with
GitHub Actions
Inactive
Matthew-Grayson
temporarily deployed
to
staging
October 13, 2023 14:53 — with
GitHub Actions
Inactive
Matthew-Grayson
temporarily deployed
to
production
October 13, 2023 14:53 — with
GitHub Actions
Inactive
Matthew-Grayson
temporarily deployed
to
production
October 13, 2023 14:59 — with
GitHub Actions
Inactive
Matthew-Grayson
temporarily deployed
to
staging
October 13, 2023 15:00 — with
GitHub Actions
Inactive
Matthew-Grayson
temporarily deployed
to
production
October 13, 2023 15:26 — with
GitHub Actions
Inactive
Matthew-Grayson
temporarily deployed
to
staging
October 13, 2023 15:26 — with
GitHub Actions
Inactive
Matthew-Grayson
temporarily deployed
to
production
October 13, 2023 17:19 — with
GitHub Actions
Inactive
Matthew-Grayson
temporarily deployed
to
staging
October 13, 2023 17:19 — with
GitHub Actions
Inactive
Matthew-Grayson
temporarily deployed
to
production
October 13, 2023 17:49 — with
GitHub Actions
Inactive
Matthew-Grayson
temporarily deployed
to
staging
October 13, 2023 17:49 — with
GitHub Actions
Inactive
Matthew-Grayson
temporarily deployed
to
production
October 13, 2023 17:58 — with
GitHub Actions
Inactive
Matthew-Grayson
temporarily deployed
to
staging
October 13, 2023 17:58 — with
GitHub Actions
Inactive
aloftus23
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor lambdas to export based on stage tag: staging lambda will export staging logs, prod lambda will export prod logs, and log groups without a tag will not be exported.
Rename command response variables for code readability.
Increase delay between exports to 30 seconds.
🗣 Description
💭 Motivation and context
Lambda exports all logs independent of stage. LimitExceededException means lambda is creating a new export task before the last one is finished.
🧪 Testing
✅ Pre-approval checklist
in code comments.
to reflect the changes in this PR.
✅ Pre-merge checklist
✅ Post-merge checklist