Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudwatch to s3 lambda #2305

Merged
merged 13 commits into from
Oct 13, 2023
Merged

Cloudwatch to s3 lambda #2305

merged 13 commits into from
Oct 13, 2023

Conversation

Matthew-Grayson
Copy link
Contributor

@Matthew-Grayson Matthew-Grayson commented Oct 13, 2023

Refactor lambdas to export based on stage tag: staging lambda will export staging logs, prod lambda will export prod logs, and log groups without a tag will not be exported.
Rename command response variables for code readability.
Increase delay between exports to 30 seconds.

🗣 Description

💭 Motivation and context

Lambda exports all logs independent of stage. LimitExceededException means lambda is creating a new export task before the last one is finished.

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@Matthew-Grayson Matthew-Grayson temporarily deployed to production October 13, 2023 14:00 — with GitHub Actions Inactive
@Matthew-Grayson Matthew-Grayson temporarily deployed to staging October 13, 2023 14:00 — with GitHub Actions Inactive
@Matthew-Grayson Matthew-Grayson temporarily deployed to staging October 13, 2023 14:53 — with GitHub Actions Inactive
@Matthew-Grayson Matthew-Grayson temporarily deployed to production October 13, 2023 14:53 — with GitHub Actions Inactive
@Matthew-Grayson Matthew-Grayson temporarily deployed to production October 13, 2023 14:59 — with GitHub Actions Inactive
@Matthew-Grayson Matthew-Grayson temporarily deployed to staging October 13, 2023 15:00 — with GitHub Actions Inactive
@Matthew-Grayson Matthew-Grayson temporarily deployed to production October 13, 2023 15:26 — with GitHub Actions Inactive
@Matthew-Grayson Matthew-Grayson temporarily deployed to staging October 13, 2023 15:26 — with GitHub Actions Inactive
@Matthew-Grayson Matthew-Grayson temporarily deployed to production October 13, 2023 17:19 — with GitHub Actions Inactive
@Matthew-Grayson Matthew-Grayson temporarily deployed to staging October 13, 2023 17:19 — with GitHub Actions Inactive
@Matthew-Grayson Matthew-Grayson temporarily deployed to production October 13, 2023 17:49 — with GitHub Actions Inactive
@Matthew-Grayson Matthew-Grayson temporarily deployed to staging October 13, 2023 17:49 — with GitHub Actions Inactive
@Matthew-Grayson Matthew-Grayson temporarily deployed to production October 13, 2023 17:58 — with GitHub Actions Inactive
@Matthew-Grayson Matthew-Grayson temporarily deployed to staging October 13, 2023 17:58 — with GitHub Actions Inactive
@Matthew-Grayson Matthew-Grayson marked this pull request as ready for review October 13, 2023 18:16
@Matthew-Grayson Matthew-Grayson merged commit 2e6cdc5 into master Oct 13, 2023
17 checks passed
@Matthew-Grayson Matthew-Grayson deleted the cloudwatch-to-s3-lambda branch October 13, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants