Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional logging to cloudWatchToS3 lambda for troubleshooting. #2272

Merged
merged 6 commits into from
Oct 5, 2023

Conversation

Matthew-Grayson
Copy link
Contributor

@Matthew-Grayson Matthew-Grayson commented Oct 2, 2023

🗣 Description

Adds console logs to enrich the cloudwatchToS3 lambda logs.
Add ssm and s3 permissions to lambda role in serverless configuration.

💭 Motivation and context

The cloudwatchToS3 lambda runs but doesn't populate the s3 bucket. Additional console logs will indicate what parts of the lambda are running and/or where it is failing.

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@Matthew-Grayson Matthew-Grayson linked an issue Oct 2, 2023 that may be closed by this pull request
6 tasks
@Matthew-Grayson Matthew-Grayson marked this pull request as ready for review October 3, 2023 15:26
Copy link
Contributor

@aloftus23 aloftus23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Matthew-Grayson Matthew-Grayson merged commit e28e872 into master Oct 5, 2023
14 checks passed
@Matthew-Grayson Matthew-Grayson deleted the 2118a-cloudwatch-to-s3-lambda branch October 5, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AU-05 - Audit Process - Migrate logs to S3 buckets
2 participants