Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud watch bucket policy #2266

Merged
merged 15 commits into from
Sep 29, 2023
Merged

Cloud watch bucket policy #2266

merged 15 commits into from
Sep 29, 2023

Conversation

Matthew-Grayson
Copy link
Contributor

@Matthew-Grayson Matthew-Grayson commented Sep 29, 2023

🗣 Description

Add bucket policy allowing CloudWatch to write to it.

💭 Motivation and context

see issue #2118

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@Matthew-Grayson Matthew-Grayson temporarily deployed to production September 29, 2023 15:51 — with GitHub Actions Inactive
@Matthew-Grayson Matthew-Grayson temporarily deployed to staging September 29, 2023 15:51 — with GitHub Actions Inactive
@Matthew-Grayson Matthew-Grayson marked this pull request as ready for review September 29, 2023 15:54
@Matthew-Grayson Matthew-Grayson merged commit f617390 into master Sep 29, 2023
9 checks passed
@Matthew-Grayson Matthew-Grayson deleted the CloudWatch-Bucket-Policy branch September 29, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants