Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2209 Footer cutting off Export Users on User page #2239

Closed
wants to merge 23 commits into from
Closed

#2209 Footer cutting off Export Users on User page #2239

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
3bd72f1
updated footer
courtneyc1 Sep 13, 2023
f25c21c
Merge branch 'master' into 2209-footer-cutting-off-export-users-page
Matthew-Grayson Sep 19, 2023
adb3443
changed footer root position to 'fixed' and reinstalled package json …
Sep 22, 2023
b233791
changed position on 'Footer' file from 'sticky' to 'fixed'
Sep 22, 2023
b0aa1f9
added zIndex to keep footer on top of other page elements
Sep 22, 2023
a4ac2b5
fixed cutoff content on 'scans' page
Sep 26, 2023
9dcb263
Merge branch 'master' into 2209-footer-cutting-off-export-users-page
Sep 26, 2023
d945487
ran 'npm test -u' locally
Sep 27, 2023
3e14b86
updated modules and dependencies on 'docs'
Sep 27, 2023
29aef9f
Merge branch 'master' of github.com:cisagov/crossfeed into 2209-foote…
Sep 28, 2023
31be255
deleted backend package-json due to merge conflicts
Sep 28, 2023
922d47a
installed merged package json files for 'docs' and 'backend'
Sep 28, 2023
8f09d7d
Merge branch 'master' into 2209-footer-cutting-off-export-users-page
courtneyc1 Sep 29, 2023
e046405
Merge branch 'master' into 2209-footer-cutting-off-export-users-page
courtneyc1 Oct 2, 2023
9ca8953
Testing this
courtneyc1 Oct 13, 2023
3cff819
npm test -u
courtneyc1 Oct 13, 2023
9970d6b
npm audit fix for frontend push
courtneyc1 Oct 13, 2023
2b28d8d
npm audit fix for docs
courtneyc1 Oct 13, 2023
576c367
Merge branch 'master' into 2209-footer-cutting-off-export-users-page
courtneyc1 Oct 13, 2023
598ae3a
Merge branch 'master' into 2209-footer-cutting-off-export-users-page
courtneyc1 Oct 16, 2023
b9d2f25
docs/package-lock.json updated
courtneyc1 Oct 16, 2023
ffa26c1
Updated Footer 'absolute' to 'relative'
courtneyc1 Oct 16, 2023
5614683
npm audit fix for frontend/vunerabilities
courtneyc1 Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions frontend/src/components/Footer/styleFooter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
};
export const FooterRoot = styled('div')(({ theme }) => ({
[`& .${footerClasses.footerBox}`]: {
position: 'absolute',
position: 'sticky',
bottom: 0,
width: '100%',
backgroundColor: theme.palette.primary.main
Expand All @@ -21,7 +21,7 @@
alignItems: 'center',
justifyContent: 'center',
margin: '0 auto',
maxWidth: '1444px'
maxWidth: '1444px',

Check failure on line 24 in frontend/src/components/Footer/styleFooter.ts

View workflow job for this annotation

GitHub Actions / lint 

Delete `,`
},
[`& .${footerClasses.footerLogo}`]: {
display: 'flex',
Expand Down
1 change: 1 addition & 0 deletions frontend/src/components/FooterOriginal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ export const CrossfeedFooter: React.FC = () => {
alignItems={'center'}
justifyContent={'center'}
style={{
position: 'sticky',
margin: '0 auto',
marginTop: '1rem',
maxWidth: '1444px'
Expand Down
Loading