#2209 Footer cutting off Export Users on User page #2239
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The footer now shows under the content for all pages. The user page under export now shows footer under it instead of cutting it off.
Matthew-Grayson
requested changes
Sep 20, 2023
|
I recommend seeing if 'position: fixed' works as better solution first as opposed to 'position: absolute' as it should allow the footer to act as a sticky footer without needed to change padding or margins. |
added 10 commits
September 22, 2023 10:43
…r-cutting-off-export-users-page
|
Failing "Docs" build check due to issues with node-module changes possibly made to master. Page able to load locally and no issues on docker logs. |
|
moving this issue to #2345 |
|
closing this issue because of current updates should fix branch conflict and build/docs issues. See #2345. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated footer page toot cut off export users under user page.
🗣 Description
go to frontend/src/components/footer/styleFooter.ts
under line 12-17 for corrections
💭 Motivation and context
footer was cutting off content of pages. User page at the bottom where export user was cut off by footer.
🧪 Testing
tested all changes within local crossed and verified before creating the PR.
Before with footer being cut off
Footer issue resolved
