-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated header (Nav Bar) for hiding reports page #2238
Conversation
commented out line 250-255 to hide page.
@epicfaace Rachel asked Courtney to hide this page until it is functional. I'd like your input as to whether we should comment it out or remove it (based on how we typically handle unused code). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would check with P&E team / Andy / Lamar before removing it. I know the page does include reports for federal agencies enrolled in P&E. If we need to use it for P&E, I’d suggest showing it only for govt agencies organizations and hiding it elsewhere.
(The reports are only visible if you select a fed agency in the organization dropdown). |
We spoke about it in the meeting today. It looks like it isn't being used on either site at the moment. The consensus was commenting out the code until we add reports functionality. |
Frontend Pipeline / test failure
Yes, in that case, let's comment it out. Good to comment it out as we might need to re-add it in the future. |
…tion declaration.
…g required in frontend/src/types/organization.ts.
I fixed the linting errors and replaced the header snapshot (the snapshot caused failure of the "Header matches snapshot" test. Additionally I fixed a type error related to the Organization interface used for testing by adding pendingDomains to testOrganization. |
updating typo Co-authored-by: Ashwin Ramaswami <[email protected]>
updated typo/ commit from Ashwin's suggestion. Updated the branch since master had some changes since then. All changes approve and branch has no conflicts. Merged to master. |
Hiding Reports page
due to no current data being presented needed to hide this page until it gets updated.
frontend/src/components/Header.tsx
commented out line 250-255 to hide page.
🗣 Description
frontend/src/components/Header.tsx
comment out line 250-255 to hide the page.
Will need to uncomment when reports page is finished.
💭 Motivation and context
Clients get confused on reports page when nothing is presented currently.
gives dev team a chance to update the reports page
🧪 Testing
used local crossed to verify changes
before when reports page was present to
reports page hide on the nav bar.