Basic implementation #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkorotkov
reviewed
May 15, 2024
| - name: Print Output | ||
| id: output | ||
| run: echo "${{ steps.test-action.outputs.time }}" | ||
| - uses: cirruslabs/swiftlint-action@v1 |
There was a problem hiding this comment.
Let's make it an example with a version. Can we do like latest for the version?
There was a problem hiding this comment.
Changed in b7c46df.
| const version: string = core.getInput('version') | ||
|
|
||
| // Fail the workflow run if we're not running on macOS | ||
| if (process.platform !== 'darwin') { |
There was a problem hiding this comment.
It seems SwiftLint supports Linux but we can work on it in a separate issue.
Co-authored-by: Fedor Korotkov <[email protected]>
fkorotkov
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm also proposing to rename the
mainbranch tov1to ease the release process.