Introduce --guest-builds-dir and --guest-cache-dir #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkorotkov
reviewed
Feb 17, 2024
README.md
Outdated
Comment on lines
148
to
151
| | `--builds-dir` | | Path to a directory on host to use for storing builds | | ||
| | `--cache-dir` | | Path to a directory on host to use for caching purposes | | ||
| | `--guest-builds-dir` | | Path to a directory in guest to use for storing builds | | ||
| | `--guest-cache-dir` | | Path to a directory in guest to use for caching purposes | |
There was a problem hiding this comment.
From reading this documentation it's not clear to me why we need --guest-* and how to set it. They are only useful when we mount a disk or a block device, right?
These options seems to mutual exclusive and both use cases should be explained.
There was a problem hiding this comment.
Improved in 58dcd76.
fkorotkov
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #60.