Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TART_EXECUTOR_INSTALL_GITLAB_RUNNER: deprecate "true" #55

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

edigaryev
Copy link
Contributor

In favor of explicit "brew" and "curl" installation methods.

Tested all combinations manually on ghcr.io/cirruslabs/macos-sonoma-base:latest.

Resolves #48.

In favor of explicit "brew" and "curl" installation methods.
@edigaryev edigaryev requested a review from fkorotkov January 15, 2024 19:10
@fkorotkov
Copy link
Contributor

What do you think of host option in the future? #48 (comment)

@edigaryev
Copy link
Contributor Author

What do you think of host option in the future? #48 (comment)

From the linked issue:

for the specific versions, tart would pick an appropriate installation method (though for simplicity's sake, i would just go for curl)

I think we should only implement host if separate brew and curl wouldn't cut it.

@fkorotkov
Copy link
Contributor

At the same time @cosmoshepcat reported that curl was flaky one day. Having a local copy transferred will make sure the config step is more stable.

We can start with this option to have an ability to choose strategy. But 'host' looks like an ideal solution for making sure runner on the host and writhing a VM is identical. 🤷‍♂️

Copy link
Contributor

@fkorotkov fkorotkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your call. Anyone interested in the 'host' strategy please create a separate issue.

@edigaryev edigaryev merged commit 2de6442 into main Jan 16, 2024
1 check passed
@umlaeute
Copy link

how does this solve #48 ? the title of my issue was "force a given version of gitlab-runner?" which i do not see addressed at all.

@edigaryev edigaryev deleted the no-runner-method-autodetection branch January 16, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

force a given version of gitlab-runner?
3 participants