prepare stage: introduce --no-auto-prune command-line flag #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkorotkov
reviewed
Nov 4, 2023
internal/commands/prepare/prepare.go
Outdated
| @@ -40,6 +41,9 @@ func NewCommand() *cobra.Command { | |||
| "Override default image memory configuration (size in megabytes or \"auto\")") | |||
| command.PersistentFlags().StringArrayVar(&customDirectoryMounts, "dir", []string{}, | |||
| "\"--dir\" arguments to pass to \"tart run\", can be specified multiple times") | |||
| command.PersistentFlags().BoolVar(&noAutoPrune, "no-auto-prune", false, | |||
There was a problem hiding this comment.
Doesn't it automatically support --no prefix for bool flags? Maybe invert it and default to true to always pool?
There was a problem hiding this comment.
Doesn't it automatically support --no prefix for bool flags?
I don't think so: spf13/pflag#214.
There was a problem hiding this comment.
What do you think of --auto-prune flag with a a default to true? Potential usage like --no-auto-prune=false looks weird to me.
fkorotkov
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitLab Runner prefixes all external environment variables passed to the custom runner with
CUSTOM_ENV_*, so#41 (comment) wouldn't work.
Since
TART_NO_AUTO_PRUNEmight influence behavior for other tasks, it makes sense to add it as a command-line flag, instead of an environment variable.