Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bunch of modifications #54

Merged
merged 16 commits into from
Nov 24, 2023
Merged

bunch of modifications #54

merged 16 commits into from
Nov 24, 2023

Conversation

BeauvillierS
Copy link
Collaborator

in summary:

  • created static csv files for the notebooks
  • changed how the results are displayed for the check_scientificname_and_ids function
  • modified the environment file to add two packages

@BeauvillierS BeauvillierS requested a review from jdpye July 6, 2023 20:27
@BeauvillierS
Copy link
Collaborator Author

BeauvillierS commented Jul 7, 2023

looks good to merge all this! @jdpye

@BeauvillierS
Copy link
Collaborator Author

@jdpye can you help with the pre-commit? can't find where it's failing

@jdpye
Copy link
Member

jdpye commented Nov 23, 2023

Looks like one of our dependencies in the github actions was deprecated recently. looking at what to fix in order to bring back our auto-checking. we can skip over pre-commit for the moment while I do that.

@jdpye
Copy link
Member

jdpye commented Nov 23, 2023

Fixes look to be either going to Python 3.9+ or pinning importlib-metadata to < 5.0 in our setup.

fixing flake tester
@jdpye jdpye merged commit fce8d88 into main Nov 24, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants