feat: added continents function #984 #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added data for continents
added module for continents
Update location.h
Update location.cpp
Update location_data.h
Update location_data.h
cieslarmichal
requested changes
Nov 17, 2024
cieslarmichal
requested changes
Nov 17, 2024
cieslarmichal
requested changes
Nov 18, 2024
cieslarmichal
approved these changes
Nov 18, 2024
charan-003
commented
Nov 18, 2024
cieslarmichal
requested changes
Nov 19, 2024
added comment africa
cieslarmichal
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added: A new continent() function to determine the continent for a given country.
Fallback: Implemented a fallback to return "Unknown" for unmapped countries.
Updates to Codebase:
Modified location.cpp and location_data.h to include continent-related logic.
Tests:
Added tests in location_test.cpp under the new LocationContinentTest suite:
shouldGenerateCorrectContinentForKnownCountry
shouldReturnUnknownForUnmappedCountry
shouldGenerateRandomContinent