Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added Palestine location data #977

Merged
merged 10 commits into from
Nov 15, 2024
Merged

feat: added Palestine location data #977

merged 10 commits into from
Nov 15, 2024

Conversation

charan-003
Copy link
Contributor

feat: added Palestine location data

  • added Palestine location data

  • added test case

@charan-003
Update location_data.h
3acba9b 
Added data for Palestine
@charan-003
Update location.cpp
28114c5 
Added case for Palestine
@charan-003
Update location_test.cpp
441f1c5 
added test cases for Palestine
@cieslarmichal cieslarmichal linked an issue Nov 15, 2024 that may be closed by this pull request
Add location addresses data from Palestine #458
Closed
@cieslarmichal
Copy link
Owner

please fix build

cieslarmichal
cieslarmichal requested changes Nov 15, 2024
View reviewed changes
tests/modules/location_test.cpp Outdated Show resolved Hide resolved
@charan-003 charan-003 marked this pull request as draft November 15, 2024 10:07
charan-003
charan-003 commented Nov 15, 2024
View reviewed changes
Copy link
Contributor Author

@charan-003 charan-003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@charan-003 charan-003 marked this pull request as ready for review November 15, 2024 10:15
charan-003
charan-003 commented Nov 15, 2024
View reviewed changes
Copy link
Contributor Author

@charan-003 charan-003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed the variable from Ar_PS to ar_PS, from palestineAddresses to PalestineAddresses

cieslarmichal
cieslarmichal requested changes Nov 15, 2024
View reviewed changes
src/modules/location_data.h Outdated Show resolved Hide resolved
@charan-003
Update location.cpp
419f8e2 
changed to camelCasing
@charan-003
Update location_data.h
43e6d37 
fixed camelCasing issues
@charan-003
Update location_test.cpp
be66ecf 
fixed the camelCasing issue
@charan-003
Update location_test.cpp
2610d89 
changed all the camelCasing for palestine
charan-003
charan-003 commented Nov 15, 2024
View reviewed changes
Copy link
Contributor Author

@charan-003 charan-003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed all the camelCasing isseus

charan-003
charan-003 commented Nov 15, 2024
View reviewed changes
Copy link
Contributor Author

@charan-003 charan-003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@charan-003
Copy link
Contributor Author

hi,
I hope this works now

@charan-003
Update location_data.h
38f5499 
changed zipcode format from P####### to ########
charan-003
charan-003 commented Nov 15, 2024
View reviewed changes
Copy link
Contributor Author

@charan-003 charan-003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed the postal code format

@cieslarmichal cieslarmichal merged commit 58d922c into cieslarmichal:main Nov 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cieslarmichal cieslarmichal cieslarmichal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add location addresses data from Palestine
2 participants
@charan-003 @cieslarmichal