Merge pull request #43 from cidilabs/PHPALLY-dont-flag-nbsp

Don't flag NBSP in text emphasis check
cidilabs · Dec 14, 2022 · 04ca1ad · 04ca1ad
2 parents e3754a3 + 4650e26
commit 04ca1ad
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/src/Rule/CssTextStyleEmphasize.php b/src/Rule/CssTextStyleEmphasize.php
@@ -61,6 +61,11 @@ public function check()
 				continue;
 			}
 
+			// skip if the element only contains whitespace
+			if(!$elementText) {
+				continue;
+			}
+
 			// skip if parent text == element text AND parent element is emphasized
 			$parentNode = $element->parentNode;
 			if ($parentNode && ($parentNode->nodeType === XML_ELEMENT_NODE)) {

diff --git a/tests/CssTextStyleEmphasizeTest.php b/tests/CssTextStyleEmphasizeTest.php
@@ -76,6 +76,9 @@ protected function getValidTestHtml()
             // emphasis tag w/ color
             "valid colored {emphasis_tag}" => "<{block_tag}><{emphasis_tag} style='color: red'>COLORED EMPHASIS</{emphasis_tag}>.</{block_tag}>",
             "valid bgcolor {emphasis_tag}" => "<{block_tag}><{emphasis_tag} style='background-color: red;'>BG COLORED EMPHASIS</{emphasis_tag}>.</{block_tag}>",
+
+            // &nbsp;
+            "valid {block_tag}, bgcolor {generic_tag}" => "<{block_tag}><{generic_tag} style='background-color: red;'>&nbsp;&nbsp;&nbsp;</{generic_tag}></{block_tag}>",
         ];
     }