Lang is a url parameter now. #316
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1063,6 +1063,8 @@ <h4 style="border-bottom: solid 1px #999; font-family:'PT Sans Narrow',Helvetica | |||
| $(".language_select select").on("change", function(){ | |||
| // set session data to new language | |||
| var language = $(this).val(); | |||
| lang = language; | |||
| updateURLQueryParameters(); | |||
| window.location = "/set_language/"+language+"/"; | |||
There was a problem hiding this comment.
Over here, the point of redirecting to /set_language/ is that the set language page sets the language cookie and redirects back to the current page. Since we're not relying on the cookie anymore, I think you can do window.location.reload() here and that should work. See if that's true - I could be wrong. You can then also remove the set_language view and get rid of it from the URLs if that's the case.
There was a problem hiding this comment.
You are correct. Have removed the /set_language/ from here and from urls.py Just takinging my time to clean it up from views.py, once am absolutely sure it's not being used anywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sibamohanty says:
Changes made
queryActivated is true all the time.
lang is updated in updateURLQueryParameters 3 .explore view has translation activated.