-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parse-zoneinfo: replace rule parser with simple state machine #172
Open
djc
wants to merge
9
commits into
main
Choose a base branch
from
no-regexx
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+4,957
−371
Open
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
3dc14b5
Use local copy of parse-zoneinfo
djc 413d981
Track files in parse-zoneinfo
djc 2833191
parse-zoneinfo: add snapshot tests
djc e9a5ccb
parse-zoneinfo: replace day_spec parser with simple Rust code
djc 30164b7
parse-zoneinfo: use simple Rust code for parsing times
djc 40c40db
parse-zoneinfo: replace rule parser with simple state machine
djc 720830c
parse-zoneinfo: use state machine for parsing zone lines
djc a538210
parse-zoneinfo: replace link parser with simple Rust code
djc 0a7f262
parse-zoneinfo: use simple Rust code to parse empty lines
djc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
use std::error::Error; | ||
|
||
use insta::assert_debug_snapshot; | ||
|
||
use parse_zoneinfo::line::{Line, LineParser}; | ||
use parse_zoneinfo::FILES; | ||
|
||
#[ignore] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I added |
||
#[test] | ||
fn test_parse() -> Result<(), Box<dyn Error + Send + Sync + 'static>> { | ||
let mut files = vec![]; | ||
let parser = LineParser::default(); | ||
for file in FILES { | ||
let path = format!("../chrono-tz/tz/{}", file); | ||
let text = std::fs::read_to_string(&path)?; | ||
let mut lines = vec![]; | ||
for ln in text.lines() { | ||
dbg!(ln); | ||
match parser.parse_str(ln)? { | ||
Line::Space => continue, | ||
ln => lines.push(format!("{:?}", ln)), | ||
} | ||
} | ||
|
||
files.push((file, lines)); | ||
} | ||
|
||
assert_debug_snapshot!(files); | ||
Ok(()) | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand why you added this test. Not sure about it though.
Would it be better to add this test as a separate crate in the workspace?