[GOLF-12281] Add webhook support to LightspeedRestaurantClient #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olimart
approved these changes
Dec 5, 2024
chen-lightspeed
force-pushed
the
feature/add-webhook-handling
branch
from
a6f8c14 to
762a85f
Compare
chen-lightspeed
changed the base branch from
master
to
GOLF-12242-external-payment-provider
lindseytruong
merged commit a09ec65
into
GOLF-12242-external-payment-provider
5 checks passed
lindseytruong
added a commit
that referenced
this pull request
Dec 9, 2024
* [GOLF-12281] Add webhook support to LightspeedRestaurantClient (#40) --------- Co-authored-by: chen-lightspeed <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request introduces webhook support to the LightspeedRestaurantClient library. The updates include:
New Webhook Class:
Added a Webhook class to manage webhook-related operations, including:
list: Retrieve a list of all webhooks.
find: Get details for a specific webhook.
create: Create a new webhook.
renew: Renew an existing webhook.
Improved Response Handling:
Updated handle_list_response to handle API responses containing results or data correctly.
Error Handling Enhancements:
Added handling for unauthorized_error in the Request module to better manage API authentication issues.
Testing Improvements:
Added VCR cassettes for webhook-related tests (create, find, list, renew) to ensure consistency and reliability in test cases.
Why These Changes Are Necessary:
This addition enhances the functionality of LightspeedRestaurantClient by enabling developers to easily manage webhooks through the library, improving usability and API coverage.
Checklist:
Added/updated unit tests.
Additional Notes:
Please review the implementation and test cases for completeness and accuracy. Feedback is appreciated!