Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pink (my WIP lua ink compiler) support #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

premek
Copy link
Contributor

@premek premek commented Apr 2, 2023

Closes #6

Hi, I see you added 'initial support for incompatible versions', please let me know if I can use it (or if I should make any changes in my PR)

I didn't include the update_site.yml file changes yet (should I?) but in my fork I run it with python3 proof.py pink_compiler pink_runtime

Another thing I wasn't sure about was that I store my compiled "bytecode" in a new file *_pink.lua.
I didn't have any file format for it as it's just a lua data structure passed from the compiler to the runtime.
So I serialized it to a lua file so I can easily 'require' (include) it in the runtime script but for that it needed to be called *.lua

I also found it useful to be able to display it so in my fork I changed the compileBytecodePath link. Would it be possible to somehow add the link to the pink.lua file too? (example: https://premek.github.io/ink-proof/#!/file/pink_compiler_I002_out_pink.lua?overview=ink )

Let me know what you think

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ink implementation with incompatible bytecode
1 participant