Update to use "prop-types" dependency #450
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d of the one from the react package. This is because accessing PropTypes from the main React package is deprecated
ottis
changed the title
|
You might want to take a look at #439 that also fixed those issues but might lead to a more elaborate rewriting apparently. |
|
Ah I see (I didn't try and tackle the createClass issue as it looked like a rewrite as you mentioned), maybe i'll jump onto that branch and see if there's anything I can help with 😄 cheers! |
|
🏆 I really wish this would be merged in and accepted into |
|
@drewlustro I'm in agreement, would be good to get rid of these annoying warnings for now, not sure when that massive rewrite is going to be merged |
|
@ottis and @drewlustro are you guys on the latest version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the console there was an annoying warning from React:
This PR adds the prop-types dependency to the project, and updates the references.
https://github.com/facebook/prop-types
Changes
Files changed
Tests/Examples
Tests are passing, examples run fine