Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix isUrl pipeline char #342

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ghost
Copy link

@ghost ghost commented May 23, 2016

The regular expression used to validate the urls, doesn't match a regular uri like this:
https://www.google.it/search?q=to+be+||+not+to+be

The problem is that the actual regex, doesn't match the "pipeline char" of the parameter's values.

@Semigradsky
Copy link
Collaborator

It makes sense to change the validator to Diego Perini variant:
https://mathiasbynens.be/demo/url-regex

@Semigradsky Semigradsky added this to the 0.19.0 milestone Aug 26, 2016
@aesopwolf
Copy link
Collaborator

I'm in favor of moving to the @dperini regex. We can hardcode, but I'd also be okay with pulling in https://github.com/kevva/url-regex. Mainly since it seems that there are occasional updates to the regex itself. So it's nice to have a repo that keeps up to date with the original gist and runs unit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants