feat(src): Allow listing devices of concrete types #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrejholy
force-pushed
the
wip/oholy/list-type
branch
2 times, most recently
from
3a3c535 to
d77e0bb
Compare
Currently, the "list" command returns all discovered devices. This includes also devices without host services like printers. That is a problem for some API clients (i.e. gvfs). Let's add an optional argument to specify concrete type. Fixes: christgau#178
christgau
force-pushed
the
wip/oholy/list-type
branch
from
a94c052 to
b5aca43
Compare
gnomesysadmins
pushed a commit
to GNOME/gvfs
that referenced
this pull request
Feb 19, 2024
The wsdd backend enumerates also printers and other unwanted devices now. It is now possible to request just devices of concrete types thanks to the christgau/wsdd#189 request. Let's specify the `pub:Computer` type to filter out those unwanted devices. Related: https://gitlab.gnome.org/GNOME/gvfs/-/merge_requests/186#note_1854469
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the "list" command returns all discovered devices. This includes also devices without host services like printers. That is a problem for some API clients (i.e. gvfs). Let's add an optional argument to specify concrete type.
Fixes: #178