Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #26 (modernize) #29

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

flowchartsman
Copy link

@flowchartsman flowchartsman commented Mar 16, 2023

Here's a first pass at modernizing the repo a little. Moves JSON file to using go embed, move to modules from dep, move to github actions from werker, etc. Probably want to remove the gopherJS stuff as well in favor of targeting wasm. I'll probably amend this PR over the next few days, so marking as WIP for now.

Edit looks like goconvey is pulling in your gopherjs deps. Not really sure what convey buys you, but if you remove it your transitive deps will basically be zero.

@flowchartsman
Copy link
Author

flowchartsman commented Mar 16, 2023

Okay, that will probably do for now. To get coverage working with the new action, you'll need to create and save one wiki page if you don't have it (the default is fine) and go to settings -> actions -> general -> workflow permissions -> read and write permissions -> save
image

@flowchartsman flowchartsman marked this pull request as ready for review March 16, 2023 05:11
@flowchartsman
Copy link
Author

Fixes #26

@flowchartsman flowchartsman changed the title WIP - Modernize Fix #26 (modernize) Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant